Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ts-bridge; harden exports; target ES2020 #469

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Switch to ts-bridge; harden exports; target ES2020 #469

wants to merge 1 commit into from

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Nov 26, 2024 •
edited
Loading

Consequently, this fixes a problem where JavaScript files were not being properly emitted in dist/.

Changelog

## Changed

- **BREAKING:** Disallow subpath exports ([#469](https://github.com/MetaMask/smart-transactions-controller/pull/469))
- **BREAKING:** Update TypeScript compilation target from ES2017 to ES2020 ([#469](https://github.com/MetaMask/smart-transactions-controller/pull/469))

## Fixed

- ESM- and CommonJS-compatible variants will now be published ([#469](https://github.com/MetaMask/smart-transactions-controller/pull/469))

Manual Testing

  • Run yarn build
  • Review dist/ to ensure that it contains all files that are needed to consume this package.

@socket-security Socket Security
Copy link

socket-security bot commented Nov 26, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ts-bridge/[email protected] None 0 192 kB mrten
npm/@ts-bridge/[email protected] filesystem, unsafe 0 72.9 kB mrten
npm/[email protected] None 0 43.7 kB sindresorhus
npm/[email protected] None 0 146 kB guybedford

🚮 Removed packages: npm/[email protected]

View full report↗︎

@mcmire mcmire marked this pull request as ready for review November 26, 2024 18:36
@mcmire mcmire requested a review from a team as a code owner November 26, 2024 18:36
@mcmire
Switch to ts-bridge; harden exports; target ES2020
dbcd010 
Consequently, this fixes a problem where JavaScript files were not being
properly emitted in `dist/`.

This is a breaking change as consumers will no longer be allowed to
import subpaths. The change to ES2020 may cause slight compatibility
issues as well.
@mcmire
Copy link
Contributor Author

mcmire commented Nov 26, 2024

Feel free to ignore this PR for now, we can merge it when we like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcmire