-
-
Notifications
You must be signed in to change notification settings - Fork 9
chore: Update @metamask/transaction-controller
peer dependency to 42.0.0
#482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update @metamask/transaction-controller
peer dependency to 42.0.0
#482
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected] |
1173f22
to
e375543
Compare
e375543
to
9a0a8ad
Compare
@@ -138,7 +139,9 @@ export type SmartTransactionsControllerGetStateAction = | |||
export type SmartTransactionsControllerActions = | |||
SmartTransactionsControllerGetStateAction; | |||
|
|||
export type AllowedActions = NetworkControllerGetNetworkClientByIdAction; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to remove these exports, but we should document this as a breaking change as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried a send transaction, swap transaction and a dapp transaction with this branch and it worked.
Update
@metamask/transaction-controller
peer dependency from38.0.0
to42.0.0
Breaking changes introduced in version
41.0.0
of@metamask/transaction-controller
affect@metamask/smart-transactions-controller
. These changes involve the removal of global network usage, requiring the explicit configuration ofnetworkClientId
. CHANGELOG