chore: Update @metamask/transaction-controller peer dependency to 42.0.0
#482
+115
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected] |
cryptodev-2s
force-pushed
the
cryptodev2s/bump-transaction-controller-42
branch
2 times, most recently
from
1173f22 to
e375543
Compare
cryptodev-2s
force-pushed
the
cryptodev2s/bump-transaction-controller-42
branch
from
e375543 to
9a0a8ad
Compare
Gudahtt
reviewed
Dec 16, 2024
| export type SmartTransactionsControllerActions = | ||
| SmartTransactionsControllerGetStateAction; | ||
|
|
||
| export type AllowedActions = NetworkControllerGetNetworkClientByIdAction; |
Member
There was a problem hiding this comment.
Good idea to remove these exports, but we should document this as a breaking change as well
cryptodev-2s
requested review from
dan437
and removed request for
matthewwalsh0
dan437
approved these changes
Dec 18, 2024
Collaborator
dan437
left a comment
dan437
left a comment
There was a problem hiding this comment.
I've tried a send transaction, swap transaction and a dapp transaction with this branch and it worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
@metamask/transaction-controllerpeer dependency from38.0.0to42.0.0Breaking changes introduced in version
41.0.0of@metamask/transaction-controlleraffect@metamask/smart-transactions-controller. These changes involve the removal of global network usage, requiring the explicit configuration ofnetworkClientId. CHANGELOG