Skip to content

chore: Update @metamask/transaction-controller peer dependency to 42.0.0 #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Dec 12, 2024

Update @metamask/transaction-controller peer dependency from 38.0.0 to 42.0.0

Breaking changes introduced in version 41.0.0 of @metamask/transaction-controller affect @metamask/smart-transactions-controller. These changes involve the removal of global network usage, requiring the explicit configuration of networkClientId. CHANGELOG

@cryptodev-2s cryptodev-2s requested a review from a team as a code owner December 12, 2024 15:52
Copy link

socket-security bot commented Dec 12, 2024

@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/bump-transaction-controller-42 branch 2 times, most recently from 1173f22 to e375543 Compare December 12, 2024 16:03
@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/bump-transaction-controller-42 branch from e375543 to 9a0a8ad Compare December 12, 2024 16:12
@cryptodev-2s cryptodev-2s self-assigned this Dec 12, 2024
@@ -138,7 +139,9 @@ export type SmartTransactionsControllerGetStateAction =
export type SmartTransactionsControllerActions =
SmartTransactionsControllerGetStateAction;

export type AllowedActions = NetworkControllerGetNetworkClientByIdAction;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to remove these exports, but we should document this as a breaking change as well

@cryptodev-2s cryptodev-2s requested a review from Gudahtt December 17, 2024 15:37
@cryptodev-2s cryptodev-2s requested review from dan437 and removed request for matthewwalsh0 December 18, 2024 14:21
Copy link
Collaborator

@dan437 dan437 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried a send transaction, swap transaction and a dapp transaction with this branch and it worked.

@cryptodev-2s cryptodev-2s merged commit c0f03c4 into main Dec 18, 2024
16 checks passed
@cryptodev-2s cryptodev-2s deleted the cryptodev2s/bump-transaction-controller-42 branch December 18, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants