feat(STX-331): migrate STX flags to smart-transactions-controller

[rarquevaux]

RemoteFeatureFlagController Integration in SmartTransactionController

This PR refactors how Smart Transactions feature flags are validated and made available to clients. This will allow clients to move away from the smart transactions properties of the swaps feature flags which are deprecated.

Key Changes:

• Flag Source: Feature flags are now read directly from RemoteFeatureFlagController:getState instead of a getFeatureFlags callback.
• Validation Timing: Flags are validated when RemoteFeatureFlagController:stateChange fires
• Per-Chain Validation: Invalid chain configs are removed individually without affecting valid chains; errors are reported to Sentry via ErrorReportingService:captureException
• Unknown Chain Safety: Chains without explicit config return hardcoded disabled defaults (all flags false)
• Messenger Requirements: Clients must configure RemoteFeatureFlagController:getState, ErrorReportingService:captureException as allowed actions, and RemoteFeatureFlagController:stateChange as allowed event
• The getFeatureFlags constructor option is deprecated and ignored.

Links to draft migration PRs:

• Extension: feat(STX-331): replace legacy swaps flags with smart transaction flags from remote config API metamask-extension#38572
• Mobile: WIP

---

Note

Reads STX feature flags from RemoteFeatureFlagController, validates on state changes with Sentry reporting, adds selectors/utilities, and deprecates getFeatureFlags.

• BREAKING:
  • Controller reads flags from RemoteFeatureFlagController:getState; getFeatureFlags constructor option deprecated/ignored.
  • Clients must allow actions RemoteFeatureFlagController:getState, ErrorReportingService:captureException and event RemoteFeatureFlagController:stateChange.
• Controller (src/SmartTransactionsController.ts):
  • Subscribes to RemoteFeatureFlagController:stateChange, validates flags, reports errors via ErrorReportingService:captureException.
  • Uses getSmartTransactionsFeatureFlags/getSmartTransactionsFeatureFlagsForChain to drive behavior (e.g., marking regular tx failed).
• Feature Flags Module (src/featureFlags/*):
  • Add validators (Superstruct) and processing for smartTransactionsNetworks; supports hex and CAIP-2 IDs.
  • Provide utilities: normalizeChainId, per-chain merge with default, and hardcoded disabled defaults for unknown chains.
• Selectors (src/selectors.ts):
  • Export selectSmartTransactionsFeatureFlags and selectSmartTransactionsFeatureFlagsForChain.
• Utils (src/utils.ts):
  • Switch getReturnTxHashAsap/shouldMarkRegularTransactionAsFailed to use network config flags.
• Tests:
  • Extensive unit tests for validators, feature flag processing/selectors, controller error reporting and behavior.
• Docs:
  • README adds feature-flag usage/migration guidance; CHANGELOG notes breaking changes.
• Deps/Peers:
  • Add @metamask/superstruct, @metamask/utils, reselect; peer deps @metamask/remote-feature-flag-controller, @metamask/error-reporting-service.

^{Written by Cursor Bugbot for commit eb0e310. This will update automatically on new commits. Configure here.}

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​metamask/​remote-feature-flag-controller@​2.0.1
	@​metamask/​error-reporting-service@​3.0.0

View full report