Skip to content

Conversation

@rarquevaux
Copy link
Contributor

@rarquevaux rarquevaux commented Dec 16, 2025

Add chainId parameter to fetchLiveness method, allowing direct chain ID specification without requiring a network client ID


Note

Add chainId to fetchLiveness, prioritizing it over networkClientId, with tests and changelog updates; deprecates networkClientId for this method.

  • SmartTransactionsController:
    • Enhance fetchLiveness to accept chainId and prefer it over networkClientId.
    • Update JSDoc; keep state updates to liveness/livenessByChainId unchanged.
  • Tests:
    • Add tests for direct chainId usage and precedence over networkClientId in fetchLiveness.
    • Minor type import adjustment in tests.
  • Changelog:
    • Add entry for new chainId option and deprecate networkClientId in fetchLiveness.

Written by Cursor Bugbot for commit e50f209. This will update automatically on new commits. Configure here.

@rarquevaux rarquevaux marked this pull request as ready for review December 16, 2025 19:06
@rarquevaux rarquevaux requested a review from a team as a code owner December 16, 2025 19:06
@rarquevaux rarquevaux force-pushed the feat/STX-338-migrate-killswitch-flags branch from c19da26 to 37d9615 Compare December 16, 2025 20:21
@rarquevaux rarquevaux force-pushed the feat/STX-338-migrate-killswitch-flags branch from 37d9615 to e50f209 Compare December 16, 2025 20:43
@rarquevaux rarquevaux merged commit 1817ca6 into main Dec 17, 2025
18 checks passed
@rarquevaux rarquevaux deleted the feat/STX-338-migrate-killswitch-flags branch December 17, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants