Fixed: handle dialog closure case in confirmation flow #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on flow When the confirmation dialog is closed (result is null), the promise should resolve with false to indicate that the user did not grant confirmation. This adds proper handling for the dialog closure scenario and includes a corresponding test case. This change ensures that the confirmation dialog properly handles the case where the user closes the dialog without making a decision, returning false instead of undefined or other unexpected values. The test case verifies this behavior.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
MoMannn
requested changes
Oct 14, 2025
jeffsmale90
reviewed
Oct 17, 2025
| // cleanup can't be defined before the click handlers, so cannot be const | ||
| // eslint-disable-next-line prefer-const | ||
| let cleanup: () => Promise<void>; | ||
| let cleanup: (resolveInterface?: boolean) => Promise<void>; |
There was a problem hiding this comment.
Not strictly related to the changes in this PR, but I'm wondering whether the cleanup function needs to be anonymous, or whether it can be a private instance method.
I think previously the unbind handlers were consts, so were within the closure in which anonymous cleanup function.
We can only have one interface open at any given time, so this.#interfaceId and this.#unbindHandlers should be sufficient for the cleanup function.
WDYT?
Maybe I'm missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the confirmation dialog is closed (result is null), the promise should resolve with false to indicate that the user did not grant confirmation. This adds proper handling for the dialog closure scenario and includes a corresponding test case.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-10-14.at.2.49.11.PM.mov
After
Screen.Recording.2025-10-14.at.2.44.23.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Handle dialog closure by resolving false and refine cleanup/unbind logic; add test coverage for closure behavior.
packages/gator-permissions-snap/src/core/confirmation.tsx):snap_dialogreturningnull(dialog closed) by cleaning up without resolving the interface and resolvingfalse.cleanupto acceptresolveInterfaceflag and safely unbind handlers with try/finally; centralize unbind logic in#unbindHandlers.packages/gator-permissions-snap/test/core/confirmation.test.ts):falsewhen dialog is closed and that event listeners are unbound.Written by Cursor Bugbot for commit 4261d0f. This will update automatically on new commits. Configure here.