feat: cache spot prices for consecutive calls#544
Merged
orestiseth merged 3 commits intomainfrom Oct 17, 2025
Merged
Conversation
ulissesferreira
approved these changes
Oct 16, 2025
xavier-brochard
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Introduce an in-memory TTL cache and use it to cache spot price lookups (30s), updating assets use cases, wiring, and tests; bump snap version.
AssetsUseCasesnow uses a cache (ICache) to store spot prices for 30s, avoiding repeated lookups; refactors fetching loop and deduplicates by ticker.index.tsinstantiatesInMemoryCacheand passes it toAssetsUseCases.ICacheinterface andInMemoryCacheimplementation with TTL, bulk ops, and expiration handling.InMemoryCache.AssetsUseCases.test.tsto mock cache and verify caching behavior.packages/snap/snap.manifest.jsonversion to1.3.0and updateshasum.Written by Cursor Bugbot for commit 4e4f228. This will update automatically on new commits. Configure here.