-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SnapError
#1833
Merged
Merged
Implement SnapError
#1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Mrtenz
force-pushed
the
mrtenz/snap-error
branch
from
October 17, 2023 12:26
5be8a5a
to
e4621d9
Compare
Mrtenz
force-pushed
the
feat/error-handling
branch
from
October 19, 2023 11:24
cbf0102
to
58b1ad9
Compare
Mrtenz
force-pushed
the
mrtenz/snap-error
branch
from
October 19, 2023 11:39
48d181c
to
6e1330d
Compare
FrederikBolding
requested changes
Oct 19, 2023
packages/snaps-execution-environments/src/common/BaseSnapExecutor.ts
Outdated
Show resolved
Hide resolved
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @metamask/[email protected] |
@metamaskbot publish-preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/error-handling #1833 +/- ##
=======================================================
+ Coverage 96.04% 96.11% +0.06%
=======================================================
Files 243 243
Lines 5669 5770 +101
Branches 899 925 +26
=======================================================
+ Hits 5445 5546 +101
Misses 224 224
☔ View full report in Codecov by Sentry. |
FrederikBolding
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
SnapError
class, and wrapping/unwrapping of errors thrown from a Snap.SnapError
s will not cause the Snap to crash, and can be used to respond to JSON-RPC requests for example.Closes #1824.