Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support utf8 encoding for snap_getFile #1858

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Oct 16, 2023

Support utf8 encoding for snap_getFile. This is useful for loading JSON or other text files.

@FrederikBolding FrederikBolding requested a review from a team as a code owner October 16, 2023 11:15
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cffc3c3) 96.03% compared to head (77f17a4) 96.06%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1858      +/-   ##
==========================================
+ Coverage   96.03%   96.06%   +0.02%     
==========================================
  Files         241      243       +2     
  Lines        5573     5663      +90     
  Branches      877      895      +18     
==========================================
+ Hits         5352     5440      +88     
- Misses        221      223       +2     
Files Coverage Δ
packages/rpc-methods/src/permitted/getFile.ts 100.00% <100.00%> (ø)
packages/rpc-methods/src/permitted/handlers.ts 100.00% <100.00%> (ø)
...ages/snaps-controllers/src/snaps/SnapController.ts 97.53% <100.00%> (+0.05%) ⬆️
...ges/snaps-simulator/src/features/manifest/sagas.ts 100.00% <100.00%> (ø)
...naps-simulator/src/features/manifest/validators.ts 84.37% <100.00%> (ø)
...ages/snaps-simulator/src/features/polling/sagas.ts 94.33% <100.00%> (+0.86%) ⬆️
...s/snaps-simulator/src/features/simulation/slice.ts 87.34% <100.00%> (+1.04%) ⬆️
packages/snaps-utils/src/auxiliary-files.ts 100.00% <100.00%> (ø)
packages/snaps-utils/src/manifest/manifest.ts 99.30% <100.00%> (+0.06%) ⬆️
packages/snaps-utils/src/manifest/validation.ts 100.00% <100.00%> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding changed the title Support plaintext encoding for snap_getFile Support utf8 encoding for snap_getFile Oct 16, 2023
@FrederikBolding FrederikBolding merged commit 3882d29 into main Oct 17, 2023
137 checks passed
@FrederikBolding FrederikBolding deleted the fb/files-api-plaintext branch October 17, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants