Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Move SnapError to SDK #1949

Merged
merged 4 commits into from
Nov 10, 2023
Merged

BREAKING: Move SnapError to SDK #1949

merged 4 commits into from
Nov 10, 2023

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 10, 2023

This moves SnapError and some used utility functions to snaps-sdk.

Breaking changes

  • SnapError was moved from snaps-utils to snaps-sdk.

@Mrtenz Mrtenz marked this pull request as ready for review November 10, 2023 13:16
@Mrtenz Mrtenz requested a review from a team as a code owner November 10, 2023 13:16
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (394c1dd) 96.04% compared to head (c3f2629) 96.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1949      +/-   ##
==========================================
+ Coverage   96.04%   96.11%   +0.06%     
==========================================
  Files         251      254       +3     
  Lines        6018     6020       +2     
  Branches      983      983              
==========================================
+ Hits         5780     5786       +6     
+ Misses        238      234       -4     
Files Coverage Δ
...ages/snaps-controllers/src/snaps/SnapController.ts 97.65% <100.00%> (ø)
...cution-environments/src/common/BaseSnapExecutor.ts 89.80% <ø> (ø)
packages/snaps-sdk/src/errors.ts 100.00% <100.00%> (ø)
packages/snaps-sdk/src/internals/errors.ts 100.00% <100.00%> (ø)
packages/snaps-sdk/src/internals/index.ts 100.00% <100.00%> (ø)
packages/snaps-utils/src/errors.ts 93.33% <100.00%> (+0.22%) ⬆️
packages/snaps-utils/src/localization.ts 100.00% <100.00%> (ø)
packages/snaps-utils/src/manifest/manifest.ts 99.35% <100.00%> (ø)
packages/snaps-webpack-plugin/src/plugin.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz Mrtenz merged commit d360f8e into main Nov 10, 2023
144 checks passed
@Mrtenz Mrtenz deleted the mrtenz/sdk-errors branch November 10, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants