Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove separate internals export from SDK #1950

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Remove separate internals export from SDK #1950

merged 5 commits into from
Nov 10, 2023

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 10, 2023

The /internals export is causing issues with Browserify. The easiest solution for now is to remove it, until we switch to the Webpack LavaMoat bundler.

@Mrtenz Mrtenz requested a review from a team as a code owner November 10, 2023 12:11
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1edfa52) 96.04% compared to head (95a8cd4) 96.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1950   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files         251      251           
  Lines        6018     6018           
  Branches      983      983           
=======================================
  Hits         5780     5780           
  Misses        238      238           
Files Coverage Δ
...ackages/snaps-rpc-methods/src/restricted/dialog.ts 100.00% <ø> (ø)
...ackages/snaps-rpc-methods/src/restricted/notify.ts 94.73% <ø> (ø)
packages/snaps-utils/src/enum.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz Mrtenz merged commit 394c1dd into main Nov 10, 2023
144 checks passed
@Mrtenz Mrtenz deleted the mrtenz/sdk-internals branch November 10, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants