Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use browser native SHA256 when possible #1953

Merged
merged 10 commits into from
Nov 13, 2023
Merged

Use browser native SHA256 when possible #1953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d329b3b
Experiment with browser native SHA256
FrederikBolding Nov 10, 2023
c6cf05e
Fix a bunch of tests and linting
FrederikBolding Nov 13, 2023
7e4fae5
Fix missing awaits!
FrederikBolding Nov 13, 2023
7349d9d
Fix more tests
FrederikBolding Nov 13, 2023
6e42a2b
Use noble-hashes if crypto.subtle is unavailable
FrederikBolding Nov 13, 2023
8ec2665
Fix more tests
FrederikBolding Nov 13, 2023
7d5eb82
Test both noble-hashes and crypto.subtle
FrederikBolding Nov 13, 2023
99a89e6
Simplify test
FrederikBolding Nov 13, 2023
3b246ad
Add getChecksumBytes function
FrederikBolding Nov 13, 2023
1719409
Update packages/snaps-utils/src/checksum.ts
FrederikBolding Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/create-snap/src/cmds/init/initHandler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import * as snapUtils from '@metamask/snaps-utils';
import {
getPackageJson,
getMockSnapFiles,
getMockSnapFilesWithUpdatedChecksum,
} from '@metamask/snaps-utils/test-utils';
import * as utils from '@metamask/utils';
import { promises as fs } from 'fs';
Expand Down Expand Up @@ -132,9 +133,10 @@ describe('initialize', () => {
.mockImplementation(() => false);
jest.spyOn(initUtils, 'gitInitWithCommit').mockImplementation();

const { manifest, packageJson } = getMockSnapFiles({
packageJson: { ...getPackageJson(), main: undefined },
});
const { manifest, packageJson } =
await getMockSnapFilesWithUpdatedChecksum({
packageJson: { ...getPackageJson(), main: undefined },
});

jest
.spyOn(snapUtils, 'readJsonFile')
Expand Down
Loading