Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use regular import to reference package.json #2871

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Oct 31, 2024

Use regular import to reference the package.json of the SDK. This makes referencing the JSON work in the browser as well when using ESM.

@FrederikBolding FrederikBolding requested a review from a team as a code owner October 31, 2024 21:54
@FrederikBolding FrederikBolding merged commit 3d7e2f2 into main Nov 1, 2024
164 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-package-json-import branch November 1, 2024 09:04
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.47%. Comparing base (965b265) to head (d5086ed).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2871   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files         486      486           
  Lines       10367    10368    +1     
  Branches     1582     1582           
=======================================
+ Hits         9794     9795    +1     
  Misses        573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants