-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onSettingsPage
export
#2911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2911 +/- ##
==========================================
+ Coverage 94.49% 94.50% +0.01%
==========================================
Files 487 488 +1
Lines 10451 10473 +22
Branches 1604 1608 +4
==========================================
+ Hits 9876 9898 +22
Misses 575 575 ☔ View full report in Codecov by Sentry. |
GuillaumeRx
force-pushed
the
gr/on-settings-page
branch
from
December 6, 2024 09:53
f2afbf9
to
10d2afb
Compare
packages/test-snaps/src/features/snaps/settings-page/SettingsPage.tsx
Outdated
Show resolved
Hide resolved
packages/test-snaps/src/features/snaps/settings-page/constants.ts
Outdated
Show resolved
Hide resolved
GuillaumeRx
force-pushed
the
gr/on-settings-page
branch
from
December 10, 2024 11:06
10d2afb
to
fa382b6
Compare
GuillaumeRx
force-pushed
the
gr/on-settings-page
branch
from
December 13, 2024 09:54
b29b285
to
b78c61c
Compare
Co-authored-by: Frederik Bolding <[email protected]>
Co-authored-by: Frederik Bolding <[email protected]>
packages/snaps-rpc-methods/src/permitted/createInterface.test.tsx
Outdated
Show resolved
Hide resolved
FrederikBolding
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
onSettingsPage
export that is used to display custom UI.Changes:
onSettingsPage
: Similar toonHomePage
this export allows you to show custom UI in MetaMask. Here it's used to display a custom section in MetaMask settings.settings-page-example-snap
) to demonstrate how to use this set of features and uses it intest-snap
Progresses: #2874