Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onSettingsPage export #2911

Merged
merged 22 commits into from
Dec 16, 2024
Merged

Add onSettingsPage export #2911

merged 22 commits into from
Dec 16, 2024

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Nov 27, 2024

This PR adds a new onSettingsPage export that is used to display custom UI.

Changes:

  • Adds a new export onSettingsPage: Similar to onHomePage this export allows you to show custom UI in MetaMask. Here it's used to display a custom section in MetaMask settings.
  • Adds a new example snap (settings-page-example-snap) to demonstrate how to use this set of features and uses it in test-snap

Progresses: #2874

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner November 27, 2024 13:13
@GuillaumeRx GuillaumeRx marked this pull request as draft November 27, 2024 13:13
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (b0036f5) to head (cbe344a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2911      +/-   ##
==========================================
+ Coverage   94.49%   94.50%   +0.01%     
==========================================
  Files         487      488       +1     
  Lines       10451    10473      +22     
  Branches     1604     1608       +4     
==========================================
+ Hits         9876     9898      +22     
  Misses        575      575              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuillaumeRx GuillaumeRx marked this pull request as ready for review December 13, 2024 15:55
@GuillaumeRx GuillaumeRx merged commit 21ee99d into main Dec 16, 2024
169 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/on-settings-page branch December 16, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants