Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable nodeEnv optimization in Webpack #2970

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Dec 20, 2024

Disable the nodeEnv optimization in the default Webpack config, this optimization would simply add the NODE_ENV environment variable set to production, but that is unnecessary since we are already defining NODE_ENV ourselves.

This prevents an issue where devs would run into warnings when attempting to set NODE_ENV themselves.

@FrederikBolding FrederikBolding marked this pull request as ready for review December 20, 2024 12:55
@FrederikBolding FrederikBolding requested a review from a team as a code owner December 20, 2024 12:55
@FrederikBolding FrederikBolding changed the title fix: Disable nodeEnv optimization in Webpack fix: Disable nodeEnv optimization in Webpack Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.71%. Comparing base (8b2bada) to head (1c29e56).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2970   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         497      497           
  Lines       10802    10802           
  Branches     1649     1649           
=======================================
  Hits        10231    10231           
  Misses        571      571           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 3e615f5 into main Dec 20, 2024
166 checks passed
@FrederikBolding FrederikBolding deleted the fb/disable-node-env-optimization branch December 20, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants