chore!: Remove snap_experimentalProviderRequest#3858
Open
FrederikBolding wants to merge 3 commits intomainfrom
Open
chore!: Remove snap_experimentalProviderRequest#3858FrederikBolding wants to merge 3 commits intomainfrom
snap_experimentalProviderRequest#3858FrederikBolding wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Looks like this file is still being referenced
packages/snaps-rpc-methods/src/permitted/index.ts:6:49 - error TS2307: Cannot find module './experimentalProviderRequest' or its corresponding type declarations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
snap_experimentalProviderRequestwhich was a temporary experimental way to provide the multichain API. We explicitly flagged that it may be removed at any time and don't know of any active use.Note
Medium Risk
Breaking API removal: any Snap relying on
snap_experimentalProviderRequestor its SDK types will fail to compile or call the method. Runtime risk is otherwise low since this mainly deletes code and associated tests.Overview
Removes the experimental
snap_experimentalProviderRequestJSON-RPC method by deleting its handler implementation and test, and unregistering it from the permittedmethodHandlersmap.Removes the corresponding SDK type exports (
ProviderRequestParams/ProviderRequestResult) by deletingprovider-request.tsand dropping it fromtypes/methods/index.ts, and slightly adjusts Jest coverage thresholds to reflect the deletion.Written by Cursor Bugbot for commit bf3d172. This will update automatically on new commits. Configure here.