Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to add a horizontal divider above auto-gen Footnotes section #47

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Mase3206
Copy link

@Mase3206 Mase3206 commented Oct 2, 2024

I wanted a more visual divider in my notes between the actual content and the footnotes. This quickly tells me that this section contains different (or a different type of) content than the above section.

I just added a toggle in the settings to enable a horizontal line above the auto-generated Footnotes section (if enabled). It does this via a conditional statement in the f-string.

I did test manually with the line enabled and disabled. Both worked as expected.

I also updated the Obsidian plugin manifest version to 0.2.0 from 0.1.3 to signify a feature update.

@Comprehensive-Jason
Copy link
Collaborator

Comprehensive-Jason commented Oct 4, 2024

Thanks for the PR! I've noticed others have wanted to customize the FootNoteSectionHeading level (#32 ), and this FR is quite similar to that. I'm thinking of just turning the FootNoteSectionHeading entry in the plugin settings into a multiline textbox so people can input exactly what they want placed as the section heading, including any dividers, newlines, etc.

I think that would be more customizable and cleaner than the current collection of requests. Thoughts?

@Mase3206
Copy link
Author

Mase3206 commented Oct 4, 2024

I like that idea! I can work on it this weekend.

@Mase3206
Copy link
Author

Mase3206 commented Oct 7, 2024

This is what I have so far. It's a non-resizable textArea with 6 rows and a monospace font. It sets the header value to the literal input entered by the user into the textArea.

I move the textArea to below the description, if that feels better. The downside is that it wastes a bunch of horizontal space, creating an empty void. You can uncomment settings.ts:94 to see what I mean.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants