Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added guidance for applying CMK encryption to existing PVCs/applying cross account CMK encryption #180

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eh8
Copy link

@eh8 eh8 commented Mar 13, 2025

No description provided.

Copy link
Contributor

@eh8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link

Learn Build status updates of commit 1f52b9b:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/aks/azure-disk-customer-managed-keys.md ⚠️Warning Details

articles/aks/azure-disk-customer-managed-keys.md

  • Line 60, Column 174: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/virtual-machines/disks-cross-tenant-customer-managed-keys?tabs=azure-cli#create-a-disk-encryption-set' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 123, Column 231: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/virtual-machines/linux/disks-enable-customer-managed-keys-cli#encrypt-existing-managed-disks' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 60, Column 174: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/virtual-machines/disks-cross-tenant-customer-managed-keys?tabs=azure-cli#create-a-disk-encryption-set' will be broken in isolated environments. Replace with a relative link.
  • Line 123, Column 231: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/virtual-machines/linux/disks-enable-customer-managed-keys-cli#encrypt-existing-managed-disks' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

Learn Build status updates of commit 3610335:

✅ Validation status: passed

File Status Preview URL Details
articles/aks/azure-disk-customer-managed-keys.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ttorble
Copy link
Contributor

ttorble commented Mar 14, 2025

@schaffererin

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants