Skip to content

Fix TCP socket finishConnect() exception handling and connection logic #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master-MC1.7.10
Choose a base branch
from
Open

Fix TCP socket finishConnect() exception handling and connection logic #3783

wants to merge 1 commit into from

Conversation

31415-n
Copy link

@31415-n 31415-n commented Jun 7, 2025

  • Fix bug where finishConnect() required multiple calls before throwing exceptions
  • Fix logic where address resolution didn't immediately attempt connection
  • After address is resolved, immediately call channel.finishConnect()
  • Ensures immediate error reporting for failed socket connections
  • Improves reliability of socket connection error handling

Fix TCP socket finishConnect() exception handling and connection logic
6aa3219 
- Fix bug where finishConnect() required multiple calls before throwing exceptions
- Fix logic where address resolution didn't immediately attempt connection
- After address is resolved, immediately call channel.finishConnect()
- Ensures immediate error reporting for failed socket connections
- Improves reliability of socket connection error handling
@asiekierka
Copy link
Contributor

Could you provide an example scenario in which this issue manifests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@31415-n @asiekierka