Skip to content

Fix popping when there is no entries in nested router #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ekrem-qb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix popping when there is no entries in nested router #2086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions auto_route/lib/src/router/controller/routing_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,8 +1146,7 @@ abstract class StackRouter extends RoutingController {
@optionalTypeArgs
Future<bool> maybePop<T extends Object?>([T? result]) async {
final NavigatorState? navigator = _navigatorKey.currentState;
if (navigator == null) return SynchronousFuture<bool>(false);
if (await navigator.maybePop<T>(result)) {
if (await navigator?.maybePop<T>(result) ?? false) {
return true;
} else if (_parent != null) {
return _parent!.maybePop<T>(result);
Expand Down