Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements and measures to task registry client #360

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ChristopherSpelt
Copy link
Contributor

Description

Describe in detail the changes you are proposing, and the rationale.

Link all GitHub issues fixed by this PR.
Make sure to first open an issue, get community approval and only then create Pull Request to resolve it.
All Pull Requests must have an issue attached to them

Resolves #

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@ChristopherSpelt ChristopherSpelt force-pushed the 323-implement-functionality-to-filter-vereisten-based-on-ai-act-profile-outcomes branch from 2d491e2 to fd5d501 Compare November 14, 2024 15:02
def get_instrument_list(self) -> RepositoryContent:
response = self.client.get(f"{TaskRegistryAPIClient.base_url}/instruments/")
async def _make_request(self, endpoint: str, params: dict[str, Any] | None = None) -> dict[str, Any]:
response = await self.client.get(f"{self.base_url}/{endpoint}", params=params)

Check notice

Code scanning / SonarCloud

Server-side requests should not be vulnerable to traversing attacks Low

Change this code to not construct the URL's path from user-controlled data. See more on SonarQube Cloud
@ChristopherSpelt ChristopherSpelt force-pushed the 323-implement-functionality-to-filter-vereisten-based-on-ai-act-profile-outcomes branch from 2feaa17 to 4aca34c Compare November 18, 2024 10:27
@ChristopherSpelt ChristopherSpelt force-pushed the 323-implement-functionality-to-filter-vereisten-based-on-ai-act-profile-outcomes branch from 4aca34c to b3a1beb Compare November 18, 2024 10:28
Copy link

sonarcloud bot commented Nov 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
94.2% Coverage on New Code (required ≥ 95%)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement functionality to filter vereisten based on ai act profile outcomes
1 participant