Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Algorithm system to algorithm #368

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Rename Algorithm system to algorithm #368

merged 2 commits into from
Nov 18, 2024

Conversation

berrydenhartog
Copy link
Member

@berrydenhartog berrydenhartog commented Nov 15, 2024 •
edited
Loading

Description

Resolves #326

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@berrydenhartog berrydenhartog changed the title Remove project table Rename Algorithm system to algorithm Nov 15, 2024
@berrydenhartog berrydenhartog force-pushed the 326-rename-algorithm-system branch 3 times, most recently from 7b0d938 to 8b1c139 Compare November 15, 2024 12:05
@berrydenhartog berrydenhartog marked this pull request as ready for review November 15, 2024 12:07
@berrydenhartog berrydenhartog requested a review from a team as a code owner November 15, 2024 12:07
@berrydenhartog berrydenhartog force-pushed the 326-rename-algorithm-system branch 2 times, most recently from 0f8f65b to 85825d8 Compare November 15, 2024 12:13
uittenbroekrobbert
uittenbroekrobbert previously approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only one small remark regarding alembic generated comments.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 18, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
1.4% Duplication on New Code

See analysis details on SonarQube Cloud

@berrydenhartog berrydenhartog merged commit ef409d5 into main Nov 18, 2024
14 checks passed
@berrydenhartog berrydenhartog deleted the 326-rename-algorithm-system branch November 18, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uittenbroekrobbert uittenbroekrobbert uittenbroekrobbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor the references of project everywhere and rename "algorithm system(s)" to "algorithm(s)"
2 participants
@berrydenhartog @uittenbroekrobbert