Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): Add host to headers if specified #373

Merged

Conversation

tomdsmartdata
Copy link
Contributor

bug: #372 Support for a proxy using SSL

Description 📝

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Updates

👉 raygun.transport pulls host header from options.http.host

Test plan 🧪

Follow reproduction steps from raygun.transport: Support for a proxy using SSL

Author to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

@TheRealAgentK
Copy link
Contributor

Thx @tomdsmartdata !

@miquelbeltran I think this is generally a feasible approach. Might be worthwhile checking if @tomdsmartdata's change is the only place where we set headers though.

@tomdsmartdata
Copy link
Contributor Author

Thx @tomdsmartdata !

@miquelbeltran I think this is generally a feasible approach. Might be worthwhile checking if @tomdsmartdata's change is the only place where we set headers though.

I only validated this with my application and opted for as minimal a change in the PR as I could, hence no automated tests.
If you do have other areas where headers are being set that you'd like addressed in this PR, I'm definitely open to helping contribute those changes and properly test them all.

@TheRealAgentK
Copy link
Contributor

TheRealAgentK commented Apr 8, 2025

@tomdsmartdata

@miquelbeltran comes online in a few hours and he's best placed to have a proper look into it.

Thanks for your comms, it's really nice to have someone reporting an issue or asking for an improvement who's really engaged with the process! 👍

@miquelbeltran miquelbeltran changed the title Add host header from options if specified fix: Add host to headers if specified Apr 8, 2025
@miquelbeltran miquelbeltran changed the title fix: Add host to headers if specified fix(sdk): Add host to headers if specified Apr 8, 2025
@miquelbeltran
Copy link
Contributor

Thanks for the contribution @tomdsmartdata
This was a bug indeed, I will proceed to merge and prepare a new release.

Re: the failing CI job. The prettier formatting is fine, just the job seems to fail to checkout the code, I will have to check why in a different pr.

@miquelbeltran miquelbeltran merged commit b7a9afe into MindscapeHQ:develop Apr 8, 2025
5 of 7 checks passed
@TheRealAgentK
Copy link
Contributor

Thx again @tomdsmartdata !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants