Fix HackyCompile for Gradle 5.1+ to ignore compilation time reporting. #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Harris-Rouquette <[email protected]>
|
Tested on gradle 5.1.1, works. |
|
This will work as a interm solution until #622 gets fully tested and the java location issues get resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An annoyance with some of the Gradle changes involves this change causing a
JavaCompiletask to try and register itself as being performance logged. The issue is that with how hacky the compilation task is performed, something something NPE from missing listeners will happen with Gradle 5.1+.Yes, it's been discussed about getting a replacement, and there's a discussion that's cropped up from the issue above, this PR simply puts a bandaid fix that works all the way up to Gradle 5.6.2 (latest release), tested on Windows 10, and macOS with Gradle versions 5.2.1, 5.1.1, 5.5, and 5.6.2. This will at least buy us some time to eventually proceed with a way forward for using artifact transformers, which is likely going to need some more time to migrate to (and of course, requires that a lot of people again migrate up Gradle versions).