Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.3] Add conventional tag for animals #10162

Draft
wants to merge 1 commit into
base: 1.21.x
Choose a base branch
from

Conversation

PaintNinja
Copy link
Contributor

Preliminary Forge port of FabricMC/fabric#4168 and neoforged/NeoForge#1596.

As per Forge's policy, I'll merge this once the other loaders merge it. This only applies to 1.21.3 at the moment, as there aren't backports of this tag to older versions of both of the other loaders yet.

@PaintNinja PaintNinja added 1.21 Common Tags This is related to the de-facto common `c` tags across loaders labels Nov 5, 2024
@autoforge autoforge bot added Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. LTS This issue/PR is related to the current LTS version. labels Nov 5, 2024
@Jonathing
Copy link
Member

It might be prudent to potentially consider backporting new tags to 1.21.1 while it is in full support. Strictly additions, not any changes to existing tags. Cross-version datapacks are pretty much a standard nowadays.

@PaintNinja
Copy link
Contributor Author

While I understand the appeal, I promised in the common tags announcement that Forge will guarantee to only have c tags that are common across all loaders for a given version, to avoid the surprising scenario of a tag not working on some loaders but only on specific MC versions.

However, seeing how Forge’s support lifecycle exceeds that of the other loaders, I don’t expect any trouble in backporting new tags to older Forge MC versions if/when the other loaders do as well.

@Jonathing
Copy link
Member

While I understand the appeal, I promised in the common tags announcement that Forge will guarantee to only have c tags that are common across all loaders for a given version, to avoid the surprising scenario of a tag not working on some loaders but only on specific MC versions.

Ah, I forgot that part of it, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21 Common Tags This is related to the de-facto common `c` tags across loaders LTS This issue/PR is related to the current LTS version. Triage This request requires the active attention of the Triage Team. Requires labelling or reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants