Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Login by social providers (Google for now) #1326

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

giovaborgogno
Copy link

@giovaborgogno giovaborgogno commented May 9, 2024

Pull Request Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ”¨ chore
  • πŸ“ docs

Relevant Issues

resolves #1193

What is in this change?

This PR introduces the ability for users to log in using their Google accounts, providing the flexibility for administrators to enable or disable this feature. Additionally, administrators can restrict login access to a specific organization's domain. The implementation is designed with a modular structure, allowing for easy integration of additional authentication providers in the future.

Additional Information

image

After enable login by google:

image

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@giovaborgogno giovaborgogno marked this pull request as ready for review May 10, 2024 00:02
@timothycarambat
Copy link
Member

Damn, this is awesome!

@emilioh93
Copy link

Hey @timothycarambat, are there any intentions to work on this PR? It looks really good

@timothycarambat
Copy link
Member

@emilioh93 There is nothing wrong with the PR, it just needs to be reviewed and we need documentation to set it up because I dont want to be responsible for 400 github issues from people setting it up incorrectly and saying it is broken!

From what i already tested, it works great & will be merged

@emilioh93
Copy link

emilioh93 commented May 15, 2024

@emilioh93 There is nothing wrong with the PR, it just needs to be reviewed and we need documentation to set it up because I dont want to be responsible for 400 github issues from people setting it up incorrectly and saying it is broken!

From what i already tested, it works great & will be merged

@timothycarambat, thanks for your reply. I agree that documentation is crucial to avoid configuration issues. I appreciate your time and effort in reviewing this PR.

@timothycarambat timothycarambat removed their assignment May 24, 2024
@matejc
Copy link

matejc commented Jun 5, 2024

What are the places where should one put the documentation?

@timothycarambat
Copy link
Member

@gh-gourneau
Copy link

Oh I am excited about this feature, thanks!

@bmkor
Copy link

bmkor commented Jul 2, 2024

It's great! It simply opens the path for other login methods such as LDAP. Ideal for self hosted in a small company.

@jlmatus
Copy link

jlmatus commented Jul 22, 2024

this would be a fantastic feature! Waiting for this to get merged.

@stguitar
Copy link

@timothycarambat I have a need for this as well, and i have taken these changes and rebuild them on the current version of anythingLLM. I will work up the docs in a PR as well. My changes will probably cause this to be closed instead. it just looked like this had fallen stale with other updates to anythingLLM.

i am doing final rounds of testing on the changes locally this week.

@stguitar
Copy link

additionally, @timothycarambat would you be OK if i added proper Saml SSO support in an additional PR separately? turns out, id rather have that than this, but I have already coded this login with google part. sorta figure they could coexist

@publicvirtualvoid
Copy link

This is a game changer - is there a reason this hasn't received much tlc? Understand LDAP/SAML are prevalent in established IT envs, but Google/OAuth is much more practical in small setups.

@stguitar
Copy link

stguitar commented Dec 15, 2024 via email

@tristanbob
Copy link

Ive been testing my changes in our dev environment a bit, but should be looking to open the PR to merge in the next week or so.

Thanks for helping push this feature towards the finish line!

Besides a domain restriction, is there a way to limit which users can log in with this method?

If not, would a CAS or SAML integration be required?

@giovaborgogno
Copy link
Author

Ive been testing my changes in our dev environment a bit, but should be looking to open the PR to merge in the next week or so.

GOAT

@stguitar
Copy link

stguitar commented Dec 15, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Single Sign-On (SSO) Authentication with Azure Active Directory, GitHub, and Google
10 participants