-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AnythingLLM Chrome Extension #2066
Conversation
β¦llm into chrome-extension
β¦kground.js into models
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some multi-user considerations to make here to prevent inadvertent access or data to those who want to use the extension, but cannot. Rather than deploy something so limiting we should expand scope to support multi-user instances since single-user instances are the default way we support the extension right now.
This review has not touched the extension
folder so once this has been addressed we can do another review for just the extension. So far, everything works great for single user.
Other considerations:
- What happens when
admin
makes a key but intended to give it to someone else? It may have been pre-registered and overwritten their extension key!
-> Solution could be a button post-create to "Auto register" or copy the key instead doing the auto-register post creation instantly.
frontend/src/pages/GeneralSettings/BrowserExtensionApiKey/BrowserExtensionApiKeyRow/index.jsx
Outdated
Show resolved
Hide resolved
...nd/src/pages/GeneralSettings/BrowserExtensionApiKey/NewBrowserExtensionApiKeyModal/index.jsx
Outdated
Show resolved
Hide resolved
...nd/src/pages/GeneralSettings/BrowserExtensionApiKey/NewBrowserExtensionApiKeyModal/index.jsx
Outdated
Show resolved
Hide resolved
β¦llm into chrome-extension
β¦when no workspaces
Pull Request Type
Relevant Issues
resolves #xxx
What is in this change?
Additional Information
Developer Validations
yarn lint
from the root of the repo & committed changes