Fix #21 key duplication issue by making leaf bindings use key release… #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… events This change fixes the issue where the last character of key bindings was being passed through to the opened window/action. Now we ensure that: - Group bindings use key press events (on press) - Leaf/terminal bindings use key release events (on release) This way, the key press is properly consumed by the action before it can be passed to the newly opened window. By treating group bindings as on press, we ensure that perfomance gains mentioned in #3 are retained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… events
This change fixes the issue where the last character of key bindings was being passed through to the opened window/action. Now we ensure that:
This way, the key press is properly consumed by the action before it can be passed to the newly opened window.
By treating group bindings as on press, we ensure that perfomance gains mentioned in #3 are retained