Skip to content

Move Diff to Thread #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025
Merged

Move Diff to Thread #959

merged 1 commit into from
Apr 19, 2025

Conversation

MitMaro
Copy link
Owner

@MitMaro MitMaro commented Apr 2, 2025

The diff process is slow on repositories with many files when copy detection is enabled.

This moves the diffing to a thread so that it can be completed outside the main UI thread, and allows for progressive loading of the diff data.

@MitMaro MitMaro self-assigned this Apr 2, 2025
@MitMaro MitMaro force-pushed the mitmaro/move-diff-to-thread branch 2 times, most recently from 29c9295 to 755a262 Compare April 8, 2025 18:00
@coveralls
Copy link

coveralls commented Apr 8, 2025

Pull Request Test Coverage Report for Build 14549493181

Details

  • 272 of 289 (94.12%) changed or added relevant lines in 17 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 97.258%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/diff/thread.rs 40 45 88.89%
src/diff/commit_diff_loader.rs 69 81 85.19%
Files with Coverage Reduction New Missed Lines %
src/diff/commit_diff_loader.rs 1 86.29%
Totals Coverage Status
Change from base Build 14541356658: -0.03%
Covered Lines: 4823
Relevant Lines: 4959

💛 - Coveralls

@MitMaro MitMaro force-pushed the mitmaro/move-diff-to-thread branch 5 times, most recently from 26f06d0 to e1c674b Compare April 19, 2025 12:59
@MitMaro MitMaro force-pushed the mitmaro/move-diff-to-thread branch from e1c674b to 34ddefe Compare April 19, 2025 13:13
@MitMaro MitMaro changed the title WIP: Move Diff to Thread Move Diff to Thread Apr 19, 2025
@MitMaro MitMaro merged commit 116be0d into master Apr 19, 2025
7 checks passed
@MitMaro MitMaro deleted the mitmaro/move-diff-to-thread branch April 19, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants