Skip to content

CT namespace test #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

Saichovsky
Copy link

Description of the change

  • Added customizable namespace names. Added a test item for ct install with custom namespace.
  • The DNS UDP and TCP services now listen on different nodePort numberss. Kubernetes does not allow same port for a service when listening on both TCP and UDP

Benefits

  • Allows users to set a custom namespace for PodMonitor and for pihole (they need not be the same). Not passing these values results in the default behaviour, except for PodMonitor, which now has a default namespace value of "pihole-prometheus".
  • Also allows the DNS service to be installed by helm without failing, when "serviceDns.nodePort" is set for service type NodePort.

Possible drawbacks

None that I can think of

Applicable issues

  • fixes #

Additional information

Checklist

Kubernetes does not allow the same port to be used by different services on different protocols
Setting a value of (nodePort + 1) for TCP to prevent this error by k8s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant