Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom completion handler queue #90

Closed
wants to merge 1 commit into from
Closed

Add custom completion handler queue #90

wants to merge 1 commit into from

Conversation

maxep
Copy link

@maxep maxep commented Sep 23, 2021

Allow dispatching callback on a different queue that .main to further allow getting Clock.now from a different thread.

See thread in #85

@Reflejo
Copy link
Contributor

Reflejo commented Aug 15, 2022

Sorry, what's the point of this change again? @maxep, this is not making Kronos thread safe, is it? Wouldn't be better to add locks around stableTime?

@maxep
Copy link
Author

maxep commented Aug 15, 2022

I forgot about that one!

Indeed, it's not making stableTime thread-safe. It was more about allowing reading Clock.now on a different queue, to avoid syncing on main.
Making stableTime atomic would be best 👍

@maxep maxep closed this Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants