-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Add a Feed Form new conditional fields #1283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! You're awesome. We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of titles with semantic prefixes:
|
*Lighthouse ran on https://mobility-feeds-dev--pr-1283-fspvjzea.web.app/ * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1283-fspvjzea.web.app/feeds * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1283-fspvjzea.web.app/feeds/gtfs/mdb-2126 * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1283-fspvjzea.web.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1283-fspvjzea.web.app/gbfs/gbfs-flamingo_porirua * (Desktop)
|
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1283-fspvjzea.web.app |
Summary:
Solves #1276 and #1277 by adding new questions and associated Cypress tests.
There was also a broken test according to the linter so I attempted to fix it based on Copilot — feel free to let me know this is totally wrong!
Expected behavior:
#1276 and #1277
Testing tips:
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.sh
to make sure you didn't break anything