Skip to content

feat: Add a Feed Form new conditional fields #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

emmambd
Copy link
Collaborator

@emmambd emmambd commented Jul 7, 2025

Summary:

Solves #1276 and #1277 by adding new questions and associated Cypress tests.

There was also a broken test according to the linter so I attempted to fix it based on Copilot — feel free to let me know this is totally wrong!

Expected behavior:
#1276 and #1277

Testing tips:

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

Copy link

welcome bot commented Jul 7, 2025

Thanks for opening this pull request! You're awesome. We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of titles with semantic prefixes:

  • fix: Bug with ssl network connections + Java module permissions.
  • feat: Initial support for multiple @PrimaryKey annotations.
  • docs: update RELEASE.md with new process
    To get this PR to the finish line, please do the following:
  • Include tests when adding/changing behavior
  • Include screenshots

@emmambd emmambd marked this pull request as draft July 7, 2025 19:00
@emmambd emmambd marked this pull request as ready for review July 7, 2025 19:57
Copy link

github-actions bot commented Jul 7, 2025

*Lighthouse ran on https://mobility-feeds-dev--pr-1283-fspvjzea.web.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 90 🟢 100 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1283-fspvjzea.web.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 89 🟢 91 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1283-fspvjzea.web.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 87 🔴 0 🟢 96 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1283-fspvjzea.web.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 93 🟠 88 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1283-fspvjzea.web.app/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 100 🟢 100 🟢 100 🟢 100

Copy link

github-actions bot commented Jul 7, 2025

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1283-fspvjzea.web.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Feed form: ask producer to clarify when license is empty Add a Feed form: ask for clarification when feed is not official
1 participant