Fix: problem fetching datasets with type 1 authentication. #1292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Datasets were not downloaded for mdb-2684.
mdb-2684 has type 1 authentication, meaning the token is passed as a query in the URL.
The base URL for this feed is:
http://api.511.org/transit/datafeeds?operator_id=CE
The code would just append
?api_key=...
to the base url, giving a resulting url with two?
The correction is to use the
&
separator if the URL already has a?
.Note this could fix other feeds with the same configuration.
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.sh
to make sure you didn't break anything