Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for Fallout 2 #101

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mrowrpurr
Copy link

@mrowrpurr mrowrpurr commented Jul 6, 2022

Automatically detects GOG and Steam installations.

Supports profile-specific .ini files:

  • ddraw.ini (sfall configuration)
  • f2_res.ini (high-res configuration)
  • I would love to support sfall-mods.ini too but it doesn't come out-of-the-box with GOG/Steam, it's just common for modders

Upon profile creation, fallout2.cfg is updated to use absolute paths to your game folder.

Without this fallout2.cfg change, the game results in an error when launching: "Couldn't find/load text fonts"

Save Games

  • Does not yet support save game images, didn't include any specific Save Game support at all

fallout2.cfg

There is an .ini file which needs its paths updated or the game won't launch. I wasn't sure where to put this code, so I put it into initializeProfile. It works but I don't know if it's the best place to put it!

Automatically detects GOG and Steam installations.

Supports .ini files:
- ddraw.ini (sfall configuration)
- f2_res.ini (high-res configuration)

Upon profile creation, fallout2.cfg is updated to use absolute paths to your game folder.

Without this fallout2.cfg change, the game results in an error when launching: "Couldn't find/load text fonts"
@mrowrpurr
Copy link
Author

I'll run black locally and update to conform to the linter

@mrowrpurr
Copy link
Author

Updated it using black! Hopefully the workflow will pass this time

Added to README
@mrowrpurr
Copy link
Author

I didn't think to add the information to the README

This PR also updates the README now (using the same formatting and information as the other games)

@mrowrpurr
Copy link
Author

mrowrpurr commented Jul 16, 2022

Added one final tweak.

The fallout2.cfg .ini-formatted file was being written with spaces around the = in the file, e.g.

[section]
key = value

; I would expect no spaces around the =, e.g.
key=value

The popular Fallout 1/2 save game editor (F12se) struggled with this format. Found the space_around_delimiters=False option which fixes this. Now all the world is happy and lovely with this .cfg file :)

@mrowrpurr
Copy link
Author

Checks ran successfully 😸

@mrowrpurr
Copy link
Author

Let me know if there's anything else I should do on my end! 🎮

@phobos2077
Copy link

Haven't seen this when I created my own version: https://gist.github.com/phobos2077/c7f1488ee98626cbbfc370ba8a5ba0a5#file-game_fallout2-py

I wonder why you have Fallout2HR.exe as executable instead of regular Fallout2.exe?

I'm looking for a way to use MO2 with Fallout2 with recent sfall version and modern-style mods. Sfall now supports a mods folder with mods_order.txt similar to archives.txt file in Bethesda games. Do you know if it's possible to add support for mod archives using the same UI as New Vegas plugin uses, for example, with just the Basic Games plugin?

You can read about my experience with MO2 here: https://www.nma-fallout.com/threads/using-mod-organizer-2-for-fallout-2-modding.221796/

@Holt59
Copy link
Member

Holt59 commented Sep 23, 2023

Thanks for the PR, you will need to rebase against master for the latest change and the move to Qt6.

@Silarn
Copy link
Member

Silarn commented Oct 19, 2023

@mrowrpurr Pinging you again so you can see the comment by Holt. Please update this to use PyQt6 imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants