Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borrowing a fix from another fork of FakeIt to fix colliding mocking ids #6

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

AlexTroyer
Copy link
Contributor

We have seen issues where mocked methods defined in different files will end up overwriting each other. This was because the identifier for the mocked methods was defined by the __COUNTER__ macro, which increments per compilation unit

This change comes from another fork of FakeIt that looks like it will merge at some point to the main repo

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4398645576

  • 8 of 8 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-4.0e**-05%**) to 99.925%

Totals Coverage Status
Change from base Build 4287243006: -4.0e-05%
Covered Lines: 4009
Relevant Lines: 4012

💛 - Coveralls

@nickgra
Copy link

nickgra commented Mar 14, 2023

Upstream PR is eranpeer/FakeIt#296

@AlexTroyer AlexTroyer merged commit b7cfeeb into master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants