Skip to content

Add missing calls to fail() when exceptions are expected to be thrown #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Pokechu22 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add missing calls to fail() when exceptions are expected to be thrown #107

Pokechu22 wants to merge 1 commit into from

Conversation

@Pokechu22
Copy link

@Pokechu22 Pokechu22 commented Nov 12, 2021

Fixes #106. Without this, the test could pass if no exception is thrown, in addition to the wanted result of a matching exception being thrown.

fail() is now called before any catch in test code, as verified by grep -B1 -r catch src/test/java: 
src/test/java/com/mojang/brigadier/arguments/DoubleArgumentTypeTest.java-            fail();
src/test/java/com/mojang/brigadier/arguments/DoubleArgumentTypeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/arguments/DoubleArgumentTypeTest.java-            fail();
src/test/java/com/mojang/brigadier/arguments/DoubleArgumentTypeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/arguments/FloatArgumentTypeTest.java-            fail();
src/test/java/com/mojang/brigadier/arguments/FloatArgumentTypeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/arguments/FloatArgumentTypeTest.java-            fail();
src/test/java/com/mojang/brigadier/arguments/FloatArgumentTypeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/arguments/IntegerArgumentTypeTest.java-            fail();
src/test/java/com/mojang/brigadier/arguments/IntegerArgumentTypeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/arguments/IntegerArgumentTypeTest.java-            fail();
src/test/java/com/mojang/brigadier/arguments/IntegerArgumentTypeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/arguments/LongArgumentTypeTest.java-            fail();
src/test/java/com/mojang/brigadier/arguments/LongArgumentTypeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/arguments/LongArgumentTypeTest.java-            fail();
src/test/java/com/mojang/brigadier/arguments/LongArgumentTypeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/tree/LiteralCommandNodeTest.java-            fail();
src/test/java/com/mojang/brigadier/tree/LiteralCommandNodeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/tree/LiteralCommandNodeTest.java-            fail();
src/test/java/com/mojang/brigadier/tree/LiteralCommandNodeTest.java:        } catch (final CommandSyntaxException ex) {

@Pokechu22
Add missing calls to fail() when exceptions are expected to be thrown
54963c9 
Fixes Mojang#106.  Without this, the test could pass if no exception is thrown, in addition to the wanted result of a matching exception being thrown.
@peterix
Copy link
Contributor

peterix commented Oct 26, 2022

Closing and reopening to rerun checks.

@peterix peterix closed this Oct 26, 2022
@peterix peterix reopened this Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@Gamebuster19901 Gamebuster19901 Gamebuster19901 approved these changes

@xtexx xtexx xtexx approved these changes

@JoshuaLim007 JoshuaLim007 JoshuaLim007 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests (where relevant) don't actually make sure that an exception was thrown.

5 participants

@Pokechu22 @peterix @Gamebuster19901 @xtexx @JoshuaLim007