Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add redirects to the equality checks for nodes. #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add redirects to the equality checks for nodes. #89

wants to merge 1 commit into from

Commits on Apr 25, 2021

  1. Add redirects to the equality checks for nodes. 

    They are added as reference equality checks rather than standard object equality checks because of a stack overflow that can occur if a redirect is to a parent of the current node. If two nodes are redirected to two different nodes that otherwise look the same, then they will not be equal, which is fine because if one of the nodes gains a new child then they won't be equal any more - so this is a sensible check to have.

Test included to demonstrate the change.
    @dualspiral
    dualspiral committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    073ee9a View commit details
    Browse the repository at this point in the history