Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for source map files creation at different path. #16

Merged
merged 7 commits into from
Mar 1, 2024

Conversation

frgarc
Copy link
Contributor

@frgarc frgarc commented Mar 1, 2024

Description

  • Adding parameter outputSourcemapPath to class BundleTaskParameters. If this parameter is provided the source map files are generated at this location.

Guidance for review

Esbuild does not support to create source map files at different location. Following suggestion from the author is to switch the sourcemap flag to external and append the required sourceMappingURL comment manually to link the files.
Here are the details: evanw/esbuild#2254

Copy link
Collaborator

@rlandav rlandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

tools/core-build-tasks/src/tasks/bundle.ts Outdated Show resolved Hide resolved
tools/core-build-tasks/src/tasks/bundle.ts Outdated Show resolved Hide resolved
tools/core-build-tasks/src/tasks/bundle.ts Outdated Show resolved Hide resolved
tools/core-build-tasks/src/tasks/bundle.ts Outdated Show resolved Hide resolved
tools/core-build-tasks/src/tasks/bundle.ts Outdated Show resolved Hide resolved
tools/core-build-tasks/src/tasks/bundle.ts Show resolved Hide resolved
@frgarc frgarc requested a review from rlandav March 1, 2024 21:07
tools/core-build-tasks/src/tasks/bundle.ts Outdated Show resolved Hide resolved
@rlandav rlandav merged commit 7ff1487 into main Mar 1, 2024
2 checks passed
@rlandav rlandav deleted the frgarc/sourceMaps branch March 1, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants