Adding lint rule for /inputpermission #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just waiting for the stable docs to update with R21 out 😄 |
tools/eslint-plugin-minecraft-linting/src/Rules/AvoidUnnecessaryCommand.test.ts
Show resolved
Hide resolved
|
@rlandav @JakeShirley wondering about the beachball changefile check, is there anything I need to do? The link still won't work as it'll be in 1.14.0 stable, but wanted to get things ready |
nvm found it in the contributing doc 😄 |
|
@sweetniamhy Is this good to go? |
Oh, yes sorry I just need to run beachball on it I'll get that going 😄 |
|
@JakeShirley when you have a chance to review |
JakeShirley
approved these changes
Oct 22, 2024
rlandav
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a lint rule for using the Player.inputPermissions API