Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force bundler to use ESM, Integrate naming-convention rule, Fix Dependabot Issue #31

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

rlandav
Copy link
Collaborator

@rlandav rlandav commented Jul 12, 2024

A few minor things

  1. While we were specifying ESM for esbuild, the base tsconfig specifying ESNext made the decision based on the file extension, so it was reverting back to commonJS. I made the change to have the base config explicitly use a bundler configuration instead, resulting in proper ESM bundled outputs from esbuild.
  2. Adding a naming convention rule just to have consistency. It's a bit opinionated and needed a few suppressions, but I'm of the mind that it's better to enforce the decision even if some people have some distaste or it needs occasional suppression 😄
  3. A dependabot fix

@rlandav rlandav requested a review from frgarc July 12, 2024 18:21
Copy link
Contributor

@frgarc frgarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rlandav rlandav merged commit 26f07ac into main Jul 12, 2024
2 checks passed
@rlandav rlandav deleted the rlanda/esmodules branch July 12, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants