Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing incoming type errors from ts 5.1.3 #130

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Sep 18, 2023

  1. Configuration menu
    Copy the full SHA
    65e876b View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. After updating to TS 5.1.3 the behavior of type inference of array ty…

    …pes looks to have changed. Previously the types of a useFacetMap for example would look like so: After 5.1.3 the types look like so: The selector arguments are infered as the union of the types of all passed in Facets, rather than each arguments type corresponding to their Facet's inner type. This change fixes that issue by explicitly making the array type we were previously extending into a tuple type. This allows TS to correctly infer the arguments' types.
    Tommy-Malone-ZOS committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    3e1f151 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Configuration menu
    Copy the full SHA
    1064e20 View commit details
    Browse the repository at this point in the history