feat: add delete file extrinsic #426
Open
+1,302
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lled by non-owner
… at the moment request_delete_file is called
snowmead
reviewed
Jul 25, 2025
snowmead
reviewed
Jul 25, 2025
snowmead
requested changes
Jul 30, 2025
| } | ||
|
|
||
| #[test] | ||
| fn delete_file_works_with_any_caller() { |
There was a problem hiding this comment.
We should add a test as well to ensure that the payment stream is updated (i.e. decreased)
| use super::*; | ||
|
|
||
| #[test] | ||
| fn delete_file_fails_with_invalid_signature() { |
There was a problem hiding this comment.
Can we add a failing and successful test to ensure that the FileOperation is Delete in the intention.
There was a problem hiding this comment.
We could do it, but as Delete is the only option in the Enum I would need to directly change bytes in the encoded message, as i dont want to add a different operation
pallets/file-system/src/utils.rs
Outdated
Comment on lines
2781
to
2815
| // Update the payment stream between the user and the BSP. If the new amount provided is zero, delete it instead. | ||
| // Note: This logic is handled by decrease_bucket_size (via apply_delta_fixed_rate_payment_stream) in the case of MSPs. | ||
| let new_amount_provided = <T::PaymentStreams as PaymentStreamsInterface>::get_dynamic_rate_payment_stream_amount_provided(&bsp_id, &file_owner) | ||
| .ok_or(Error::<T>::DynamicRatePaymentStreamNotFound)? | ||
| .saturating_sub(size); | ||
| if new_amount_provided.is_zero() { | ||
| <T::PaymentStreams as PaymentStreamsInterface>::delete_dynamic_rate_payment_stream( | ||
| &bsp_id, | ||
| &file_owner, | ||
| )?; | ||
| } else { | ||
| <T::PaymentStreams as PaymentStreamsInterface>::update_dynamic_rate_payment_stream( | ||
| &bsp_id, | ||
| &file_owner, | ||
| &new_amount_provided, | ||
| )?; | ||
| } | ||
|
|
||
| // If the root of the BSP is now the default root, stop its cycles. | ||
| if new_root == <T::Providers as shp_traits::ReadProvidersInterface>::get_default_root() { | ||
| // Check the current used capacity of the BSP. Since its root is the default one, it should | ||
| // be zero. | ||
| let used_capacity = | ||
| <T::Providers as ReadStorageProvidersInterface>::get_used_capacity(&bsp_id); | ||
| if !used_capacity.is_zero() { | ||
| // Emit event if we have inconsistency. We can later monitor for those. | ||
| Self::deposit_event(Event::UsedCapacityShouldBeZero { | ||
| actual_used_capacity: used_capacity, | ||
| }); | ||
| } | ||
|
|
||
| // Stop the BSP's challenge and randomness cycles. | ||
| <T::ProofDealer as shp_traits::ProofsDealerInterface>::stop_challenge_cycle(&bsp_id)?; | ||
| <T::CrRandomness as CommitRevealRandomnessInterface>::stop_randomness_cycle(&bsp_id)?; | ||
| }; |
There was a problem hiding this comment.
Can we deduplicate this - we have the same logical sequence in do_bsp_confirm_stop_storing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new delete_file extrinsic that allows any entity (fishermen, MSPs, BSPs) to execute file deletions on behalf of users using signed intentions and forest proof verification.