-
Notifications
You must be signed in to change notification settings - Fork 11
feat(msp): rejected storage request triggers file clean up if needed #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…letion. wip: debugging
snowmead
reviewed
Nov 4, 2025
snowmead
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B5-clientnoteworthy
Changes should be mentioned client-related release notes
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
D2-noauditneeded🙈
PR doesn't need to be audited
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
File deletion from file storage are only being triggered by
MutationsAppliedevent. This is correct for the happy paths as this event is emitted always that an msp accepted the storage request (thus it root was updated in the runtime) and now is not required anymore, either because the user wants to delete it, or the user revoke the SR.But this leaves us with the edge case where the msp try to accept the SR (thus, it stores the file), but the transaction fails and his root is not updated on-chain. In this case, he will never see
MutationsAppliedevent.Solution:
Make msp react to events that inform that the SR was incomplete (
StorageRequestRejected) but MSP could have sent a tx accepting it that ends up failing.StorageRequestRejectedevent contains two new fields:msp_idandbucket_id. leaving the new struct as follows: