Skip to content

Conversation

@TDemeco
Copy link
Contributor

@TDemeco TDemeco commented Nov 5, 2025

This PR:

  • Fixes a bug where the returned value of query_earliest_file_volunteer_tick was incorrect, as we were adding the ticks that the BSP should wait to volunteer to the tick where the storage request was created instead of to the current tick, and we were using a truncating div instead of a ceiling one, making the BSP underestimate how much it had to wait before volunteering.
    • This was making it so if this was called in the same tick as the storage request was created the result was correct, but after that it decremented as the current tick increased, giving false results.
    • I added an integration test suite inside single-volunteer.test.ts file that checks that we now always get the correct result from this runtime API.
  • Updates the BSP task that handles volunteering to better handle errors and successes (with logs) and to also check if the BSP correctly volunteered on-chain before retrying, in case the first volunteer extrinsic timed out but was included on-chain.
  • As a bonus, improves logging for the MSP by adding logs when it correctly responds to a batch of files, logging both the accepted and rejected file keys.

@TDemeco TDemeco requested a review from ffarall November 5, 2025 18:40
@TDemeco TDemeco added B5-clientnoteworthy Changes should be mentioned client-related release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial👶 PR contains trivial changes that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Nov 5, 2025
@TDemeco TDemeco requested a review from ffarall November 6, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B5-clientnoteworthy Changes should be mentioned client-related release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial👶 PR contains trivial changes that do not require an audit not-breaking Does not need to be mentioned in breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants