Skip to content

Conversation

@ffarall
Copy link
Collaborator

@ffarall ffarall commented Dec 8, 2025

DO NOT MERGE YET ‼️

  1. Add checks to see if the bucket is being moved in:
    1. do_delete_bucket. A bucket shouldn't be deleted if it's being moved.
    2. delete_files_from_bucket. A file shouldn't be deleted from a bucket's root when there's a new MSP potentially reconstructing the bucket's Forest.
    3. delete_files_from_bsp. We avoid removing files from BSPs when the file belongs to a bucket being moved. This is so that BSPs don't delete files that the new MSP will potentially be asking of them.

TODOs:

  • Adjust Fisherman's batch deletion logic to prevent sending deletions of files while their bucket is being moved.
  • Consider adding extrinsic for user to cancel move bucket request. This would trickle down to MSP behaviour too.

@blacksmith-sh
Copy link
Contributor

blacksmith-sh bot commented Dec 8, 2025

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
tests/wallet/metamask-sdk-sign.spec.ts/MetaMask + SDK View Logs

Fix in Cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants