fix: 🐛 Prevent bucket and file deletions while bucket is moving #606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET‼️
do_delete_bucket. A bucket shouldn't be deleted if it's being moved.delete_files_from_bucket. A file shouldn't be deleted from a bucket's root when there's a new MSP potentially reconstructing the bucket's Forest.delete_files_from_bsp. We avoid removing files from BSPs when the file belongs to a bucket being moved. This is so that BSPs don't delete files that the new MSP will potentially be asking of them.TODOs: