-
Notifications
You must be signed in to change notification settings - Fork 11
call wallet client.write contract instead cotract.write #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
call wallet client.write contract instead cotract.write #618
Conversation
ftheirs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a description explaining the changes and why this helps with the social login?
Replacing this
return await contract.write.deleteBucket?.(args, txOpts);
with this:
return await this.walletClient.writeContract({
account: this.walletClient.account?.address as `0x${string}`,
address: this.filesystemContractAddress,
abi: filesystemAbi,
functionName: "deleteBucket",
args,
...txOpts,
chain: null
});
doesn't look good since we are loosing the autocomplete and we have to pay extra attention to the name from the different methods from precompiles.
Hi, thank you for point out the type's issue. I have fixed it and now types for args and function names should work properly. About the social login and why it is working. Looks like e.g. This is what solution I have found, and I don't have any better for now. If you know how we can do it better, please let me know. |
|
Hey @Rihyx, thanks for the clarification! The changes looks good, just make the CI ✅ |
Hi, thanks. I fixed linter. Is it possible to release some |
|
Hey @Rihyx, sure! Version |

No description provided.