bench: update delete_files_bucket and delete_files_bsp benchmarks for worst case scenario
#621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… worst-case scenario Updated benchmarks to include active storage requests for each file being deleted, ensuring weights capture the cost of cleanup_storage_request and add_incomplete_storage_request operations. This reflects the worst-case scenario where files have pending storage requests that must be cleaned up.
- Register BSP via add_bsp_to_provider_storage in delete_files_bucket to match patterns used in other benchmarks - Consolidate "worst-case scenario" mentions to single clear comment - Remove redundant inline comment headers
snowmead
added
B7-runtimenoteworthy
Update delete_files_bucket and delete_files_bsp benchmarks to add MaxReplicationTarget BSPs per storage request instead of just 1. This ensures the weights properly account for the worst-case cost of: - Iterating over all BSPs in IncompleteStorageRequestMetadata::from - Draining all BSPs via drain_prefix in cleanup_storage_request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
delete_files_bucketanddelete_files_bspbenchmarks to capture the worst-case scenario where files being deleted have active storage requests with maximum BSP participation.Weight Impact
delete_files_bucketdelete_files_bsp