feat(bsp): add retry logic for confirm storing proof errors #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements automatic retry for BSP confirm storing when proof errors occur
due to concurrent operations (e.g., file deletions modifying the forest) and transient errors.
- Add `query_pending_bsp_confirm_storage_requests` runtime API to filter
file keys that still need confirmation (excludes already confirmed,
non-volunteer, or non-existent storage requests)
- Implement handler in blockchain-service for the new query command
- Update BSP upload task to:
- Pre-filter storage requests using the new runtime API before proof
generation
- Handle `ForestProofVerificationFailed` and `FailedToApplyDelta` errors
by re-queuing file keys for automatic retry
- Add integration test verifying retry behavior when a concurrent delete
causes proof failure
snowmead
added
B5-clientnoteworthy
# Conflicts: # client/blockchain-service/src/handler.rs # client/src/tasks/bsp_upload_file.rs
Removes unused import that was introduced during merge conflict resolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements automatic retry for BSP confirm storing when proof errors occur due to concurrent operations (e.g., file deletions modifying the forest) and transient errors.
ForestProofVerificationFailedandFailedToApplyDeltaerrors by re-queuing filequery_pending_bsp_confirm_storage_requestsruntime API to filter file keys that still need confirmation (excludes already confirmed, non-volunteer, or non-existent storage requests)