Skip to content

Conversation

@elfedy
Copy link
Collaborator

@elfedy elfedy commented Aug 20, 2025

  • Use handlebars to write templates.
  • Replace prompt "handler" logic as now rendering the prompt is the same for all.
  • Move all Prompts to a dedicated file
  • Simplify some of the analysis prompts
  • Add tests to ensure prompts render correctly using the handle_get_prompt entrypoint.
  • Organize README a little bit better.

@snowmead
Copy link
Collaborator

snowmead commented Aug 20, 2025

I keep the fork of modelcontextprotocol/rust-sdk up to date. If you want to avoid doing all the manual work of implementing the prompt protocol - you can import from:

git = "https://github.com/snowmead/rust-sdk", branch = "feature/prompt-support"

Once merged, you can switch back to upstream

@elfedy elfedy requested review from GMKrieger and notlesh August 20, 2025 17:00
&self,
request: GetPromptRequestParam,
context: RequestContext<RoleServer>,
_context: RequestContext<RoleServer>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this fn from the ServerHandler trait?

Copy link
Collaborator Author

@elfedy elfedy Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trait comes from rmcp crate and is used to then implement the mcp protocol. Also, we might want to use the context at some point, for example to implement logging.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, duh, I was thinking ServerHandler came from our crate. 🥵

Copy link
Contributor

@notlesh notlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a couple minor comments.

@elfedy elfedy merged commit 8eaa82d into main Aug 20, 2025
3 checks passed
@elfedy elfedy deleted the elfedy-handlebars branch August 20, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants