-
Notifications
You must be signed in to change notification settings - Fork 3
Add handlebars templates for prompts #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I keep the fork of
Once merged, you can switch back to upstream |
| &self, | ||
| request: GetPromptRequestParam, | ||
| context: RequestContext<RoleServer>, | ||
| _context: RequestContext<RoleServer>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove this fn from the ServerHandler trait?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trait comes from rmcp crate and is used to then implement the mcp protocol. Also, we might want to use the context at some point, for example to implement logging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, duh, I was thinking ServerHandler came from our crate. 🥵
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left a couple minor comments.
handle_get_promptentrypoint.