catch sign_and_submit_then_watch_default panic #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
reviewed
Aug 22, 2025
| ) | ||
| .catch_unwind() | ||
| .await | ||
| .map_err(|_| { |
There was a problem hiding this comment.
Is the error useful here? It might help to pass this on, esp. if we find it panics for reasons other than the one assumed here.
There was a problem hiding this comment.
In theory yes but in practice we don't expect this to panic ever for no reason other than the one we were getting. What we probably need to do is make the server panic proof and catch panics at the global level (not just this call). At that point the error info becomes more useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sign_and_submit_then_watch_defaultpanics when a transaction has valid pallet and call names but the argument SCALE value does not match the expected type. This is the case forsubmit_dev_extrinsicwhen argument is a valid stringifyable scale value but it does not match the call type exactly, and made the server behave unexpectedly.