fix: update prompt return types for rmcp 0.13.0 and preserve argument order #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update rmcp dependency version in Cargo.toml - Add new required fields to Implementation struct (title, icons, website_url) - Add new required fields to RawResource structs (icons, meta, title) - Add task field to CallToolRequestParam in test helper The upgrade brings new features like graceful shutdown, task support, and elicitation improvements which can be adopted in future updates.
… order - Change prompt handler return type from `Vec<PromptMessage>` to `Result<GetPromptResult, McpError>` as required by rmcp 0.13.0 - Add `preserve_order` feature to schemars to fix positional argument mapping (prevents alphabetical reordering of schema properties) - Add prompt tests to verify the fix Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Vec<PromptMessage>toResult<GetPromptResult, McpError>(required by rmcp 0.13.0 API)preserve_orderfeature to schemars to fix positional argument mapping bugProblem
After upgrading to rmcp 0.13.0, prompts failed with "missing field release" errors when using positional arguments (e.g.,
/substrate:analyze_release stable2503). This was caused by:focusto appear beforerelease, so positional args mapped incorrectlyTest plan
cargo testpasses/substrate:analyze_release stable2503works correctly🤖 Generated with Claude Code